ChatGPT解决这个技术问题 Extra ChatGPT

What's the most efficient way to test if two ranges overlap?

Given two inclusive ranges [x1:x2] and [y1:y2], where x1 ≤ x2 and y1 ≤ y2, what is the most efficient way to test whether there is any overlap of the two ranges?

A simple implementation is as follows:

bool testOverlap(int x1, int x2, int y1, int y2) {
  return (x1 >= y1 && x1 <= y2) ||
         (x2 >= y1 && x2 <= y2) ||
         (y1 >= x1 && y1 <= x2) ||
         (y2 >= x1 && y2 <= x2);
}

But I expect there are more efficient ways to compute this.

What method would be the most efficient in terms of fewest operations?

Might be interestingly related for some - stackoverflow.com/q/17138760/104380

K
Kakshil Shah

What does it mean for the ranges to overlap? It means there exists some number C which is in both ranges, i.e.

x1 <= C <= x2

and

y1 <= C <= y2

To avoid confusion, considering the ranges are: [x1:x2] and [y1:y2]

Now, if we are allowed to assume that the ranges are well-formed (so that x1 <= x2 and y1 <= y2) then it is sufficient to test

x1 <= y2 && y1 <= x2

OR

(StartA <= EndB) and (EndA >= StartB)


I believe it should be x1 <= y2 && y1 >= x2, no?
@DavidBeck: no, if y1 > x2 then the ranges definitely don't overlap (e.g. consider [1:2] and [3:4]: y1 = 3 and x2 = 2, so y1 > x2, but there's no overlap).
this would be a better answer if you explained the reasoning a bit more
@Vineet Deoraj - Why do you think it doesn't work? x1 = 1, y1 = 1, x2 = 1, y2 = 1, so x1 <= y2 && y1 <= x2 is true, thus, there is an overlap.
K
KFL

Given two ranges [x1,x2], [y1,y2]

def is_overlapping(x1,x2,y1,y2):
    return max(x1,y1) <= min(x2,y2)

@uyuyuy99 - only not so efficient, because when this check is being done many times per second, calling function is something you would like to avoid, and do as much math yourself, keep it to the basic
@vsync Modern browsers will inline & optimize functions like Math.max, there should be no noticeable impact on performance.
@AshtonWar - interesting. do you have an article explaining what gets inlined and what's not?
@vsync No, but I'm sure you can find the information yourself
In addition, note that min(x2,y2) - max(x1,y1) provides the amount of overlap in case you need that.
F
FloatingRock

This can easily warp a normal human brain, so I've found a visual approach to be easier to understand:

https://i.stack.imgur.com/6iULg.png

le Explanation

If two ranges are "too fat" to fit in a slot that is exactly the sum of the width of both, then they overlap.

For ranges [a1, a2] and [b1, b2] this would be:

/**
 * we are testing for:
 *     max point - min point < w1 + w2    
 **/
if max(a2, b2) - min(a1, b1) < (a2 - a1) + (b2 - b1) {
  // too fat -- they overlap!
}

There are more cases than depicted in your pictures. E.g., what if w2 starts before w1 and ends after w1?
@WilliamKF the logic stands true
Agreed, but I think it might help to provide a third picture.
@WilliamKF then you need a lot of more images there are 16 different combinations that 2 ranges can be placed in...
Be careful if you use this method, because the sum a2 - a1 + b2 - b1 can overflow. To fix it, rearrange the formula to max(a2, b2) - a2 - b2 < min(a1, b1) - a1 - b1, which simplifies to max(a1, b1) < min(a2, b2), saving some arithmetic and avoiding any possible overflows (this is AXE-Labs's answer below). In the special case where you know b2-b1=a2-a1, another useful rearrangement of FloatingRock's formula is max(a2, b2) - min(a1, b1) - (b2 - b1) < a2-a1, which becomes abs(b1-a1) < a2 - a1.
C
Community

Great answer from Simon, but for me it was easier to think about reverse case.

When do 2 ranges not overlap? They don't overlap when one of them starts after the other one ends:

dont_overlap = x2 < y1 || x1 > y2

Now it easy to express when they do overlap:

overlap = !dont_overlap = !(x2 < y1 || x1 > y2) = (x2 >= y1 && x1 <= y2)

To me, easier to understand expression is : x2 < y1 || y2 < x1 // where I use 'less than' instead of "greater than".
A
AXE Labs

Subtracting the Minimum of the ends of the ranges from the Maximum of the beginning seems to do the trick. If the result is less than or equal to zero, we have an overlap. This visualizes it well:

https://i.stack.imgur.com/h2Nw2.png


This covers all cases
r
ruslik

I suppose the question was about the fastest, not the shortest code. The fastest version have to avoid branches, so we can write something like this:

for simple case:

static inline bool check_ov1(int x1, int x2, int y1, int y2){
    // insetead of x1 < y2 && y1 < x2
    return (bool)(((unsigned int)((y1-x2)&(x1-y2))) >> (sizeof(int)*8-1));
};

or, for this case:

static inline bool check_ov2(int x1, int x2, int y1, int y2){
    // insetead of x1 <= y2 && y1 <= x2
    return (bool)((((unsigned int)((x2-y1)|(y2-x1))) >> (sizeof(int)*8-1))^1);
};

Have faith in your compiler. The expression x1 <= y2 && y1 <= x2 doesn't have any branches in it either, assuming a reasonably competent compiler and CPU architecture (even in 2010). In fact, on x86, the generated code is basically identical for the simple expression vs. the code in this answer.
B
BlueRaja - Danny Pflughoeft
return x2 >= y1 && x1 <= y2;

this is not correct. Because x1 <= y1 && x2 >= y2 || x1 >= y1 && x2 <= y2 should also return true.
Y
Yankuan Zhang

If you were dealing with, given two ranges [x1:x2] and [y1:y2], natural / anti-natural order ranges at the same time where:

natural order: x1 <= x2 && y1 <= y2 or

anti-natural order: x1 >= x2 && y1 >= y2

then you may want to use this to check:

they are overlapped <=> (y2 - x1) * (x2 - y1) >= 0

where only four operations are involved:

two subtractions

one multiplication

one comparison


V
Victor.dMdB

If someone is looking for a one-liner which calculates the actual overlap:

int overlap = ( x2 > y1 || y2 < x1 ) ? 0 : (y2 >= y1 && x2 <= y1 ? y1 : y2) - ( x2 <= x1 && y2 >= x1 ? x1 : x2) + 1; //max 11 operations

If you want a couple fewer operations, but a couple more variables:

bool b1 = x2 <= y1;
bool b2 = y2 >= x1;
int overlap = ( !b1 || !b2 ) ? 0 : (y2 >= y1 && b1 ? y1 : y2) - ( x2 <= x1 && b2 ? x1 : x2) + 1; // max 9 operations

D
Duke

Think in the inverse way: how to make the 2 ranges not overlap? Given [x1, x2], then [y1, y2] should be outside [x1, x2], i.e., y1 < y2 < x1 or x2 < y1 < y2 which is equivalent to y2 < x1 or x2 < y1.

Therefore, the condition to make the 2 ranges overlap: not(y2 < x1 or x2 < y1), which is equivalent to y2 >= x1 and x2 >= y1 (same with the accepted answer by Simon).


Looks the same as what @damluar answered (Mar 2 '16 at 17:36)
M
Mark H

You have the most efficient representation already - it's the bare minimum that needs to be checked unless you know for sure that x1 < x2 etc, then use the solutions others have provided.

You should probably note that some compilers will actually optimise this for you - by returning as soon as any of those 4 expressions return true. If one returns true, so will the end result - so the other checks can just be skipped.


All compilers will. All (to my knowledge) currently-used languages with C-style syntax (C, C++, C#, Java, etc.) employ short-circuited boolean operators and it is part of the various standards that govern those languages. If the result of the lefthand value is sufficient to determine the result of the operation, the righthand value is not evaluated.
Mark H -- the compiler will skip over the second clause if it can: so if you have a function that says: foo(int c) { int i=0; if (c < 3 || ++i == argc) printf("Inside\n"); printf("i is %d\n", i); Foo(2) will print: Inside i is 0 and Foo(4) will print: i is 1 (tested on gcc 4.4.3, but I've relied on this behavior for some ugly code in icc as well)
A
Ajeet47

My case is different. i want check two time ranges overlap. there should not be a unit time overlap. here is Go implementation.

    func CheckRange(as, ae, bs, be int) bool {
    return (as >= be) != (ae > bs)
    }

Test cases

if CheckRange(2, 8, 2, 4) != true {
        t.Error("Expected 2,8,2,4 to equal TRUE")
    }

    if CheckRange(2, 8, 2, 4) != true {
        t.Error("Expected 2,8,2,4 to equal TRUE")
    }

    if CheckRange(2, 8, 6, 9) != true {
        t.Error("Expected 2,8,6,9 to equal TRUE")
    }

    if CheckRange(2, 8, 8, 9) != false {
        t.Error("Expected 2,8,8,9 to equal FALSE")
    }

    if CheckRange(2, 8, 4, 6) != true {
        t.Error("Expected 2,8,4,6 to equal TRUE")
    }

    if CheckRange(2, 8, 1, 9) != true {
        t.Error("Expected 2,8,1,9 to equal TRUE")
    }

    if CheckRange(4, 8, 1, 3) != false {
        t.Error("Expected 4,8,1,3 to equal FALSE")
    }

    if CheckRange(4, 8, 1, 4) != false {
        t.Error("Expected 4,8,1,4 to equal FALSE")
    }

    if CheckRange(2, 5, 6, 9) != false {
        t.Error("Expected 2,5,6,9 to equal FALSE")
    }

    if CheckRange(2, 5, 5, 9) != false {
        t.Error("Expected 2,5,5,9 to equal FALSE")
    }

you can see there is XOR pattern in boundary comparison


I
Ioana Bacila

Given: [x1,x2] [y1,y2] then x1 <= y2 || x2 >= y1 would work always. as

      x1 ... x2
y1 .... y2

if x1 > y2 then they do not overlap or

x1 ... x2
    y1 ... y2

if x2 < y1 they do not overlap.


this should be an AND, not an OR.
C
Codeformer

Nothing new. Just more readable.

def overlap(event_1, event_2):

    start_time_1 = event_1[0]
    end_time_1 = event_1[1]

    start_time_2 = event_2[0]
    end_time_2 = event_2[1]

    start_late = max(start_time_1, start_time_2)
    end_early = min(end_time_1, end_time_2)


    # The event that starts late should only be after the event ending early.
    if start_late > end_early:
        print("Absoloutly No overlap!")
    else:
        print("Events do overlap!")

M
Marius Amado-Alves

Overlap (X, Y) := if (X1 <= Y1) then (Y1 <= X2) else (X1 <= Y2).

PROOF:

Consider the case when X precedes, or is left aligned with, Y, i.e., X1 <= Y1. Then either Y starts inside, or at the end of, X, i.e. Y1 <= X2; or else Y is away from X. The first condition is overlap; the second, not.

In the complementary case when Y precedes X, the same logic applies to the swapped entities.

So,

Overlap (X, Y) := if (X1 <= Y1) then (Y1 <= X2) else Overlap (Y, X).

But this does not seem quite right. On the recursive call, the first test is redundant, as we already know the relative position of the entities from the first test on the first call. So, we really only need to test for the second condition, which, upon swapping, is (X1 <= Y2). So,

Overlap (X, Y) := if (X1 <= Y1) then (Y1 <= X2) else (X1 <= Y2).

QED.

Implementation in Ada:

   type Range_T is array (1 .. 2) of Integer;

   function Overlap (X, Y: Range_T) return Boolean is
     (if X(1) <= Y(1) then Y(1) <= X(2) else X(1) <= Y(2));

Test program:

with Ada.Text_IO; use Ada.Text_IO;

procedure Main is

   type Range_T is array (1 .. 2) of Integer;

   function Overlap (X, Y: Range_T) return Boolean is
     (if X(1) <= Y(1) then Y(1) <= X(2) else X(1) <= Y(2));

   function Img (X: Range_T) return String is
     (" [" & X(1)'Img & X(2)'Img & " ] ");

   procedure Test (X, Y: Range_T; Expect: Boolean) is
      B: Boolean := Overlap (X, Y);
   begin
      Put_Line
        (Img (X) & " and " & Img (Y) &
         (if B then " overlap .......... "
               else " do not overlap ... ") &
         (if B = Expect then "PASS" else "FAIL"));
   end;
         
begin
   Test ( (1, 2), (2, 3), True);  --  chained
   Test ( (2, 3), (1, 2), True);

   Test ( (4, 9), (5, 7), True);  --  inside
   Test ( (5, 7), (4, 9), True);

   Test ( (1, 5), (3, 7), True);  --  proper overlap
   Test ( (3, 7), (1, 5), True);

   Test ( (1, 2), (3, 4), False);  -- back to back
   Test ( (3, 4), (1, 2), False);

   Test ( (1, 2), (5, 7), False);  -- disjoint
   Test ( (5, 7), (1, 2), False);
end;

Output of above program:

 [ 1 2 ]  and  [ 2 3 ]  overlap .......... PASS
 [ 2 3 ]  and  [ 1 2 ]  overlap .......... PASS
 [ 4 9 ]  and  [ 5 7 ]  overlap .......... PASS
 [ 5 7 ]  and  [ 4 9 ]  overlap .......... PASS
 [ 1 5 ]  and  [ 3 7 ]  overlap .......... PASS
 [ 3 7 ]  and  [ 1 5 ]  overlap .......... PASS
 [ 1 2 ]  and  [ 3 4 ]  do not overlap ... PASS
 [ 3 4 ]  and  [ 1 2 ]  do not overlap ... PASS
 [ 1 2 ]  and  [ 5 7 ]  do not overlap ... PASS
 [ 5 7 ]  and  [ 1 2 ]  do not overlap ... PASS

H
Haywood Jablomey

Here's my version:

int xmin = min(x1,x2)
  , xmax = max(x1,x2)
  , ymin = min(y1,y2)
  , ymax = max(y1,y2);

for (int i = xmin; i < xmax; ++i)
    if (ymin <= i && i <= ymax)
        return true;

return false;

Unless you're running some high-performance range-checker on billions of widely-spaced integers, our versions should perform similarly. My point is, this is micro-optimization.


I think you've gone over the specification here. It's assumed that x1 to x2 is ascending/decending (either way, it's sorted) - there's no need for a loop, you only need to check the head and tail elements. I do prefer the min/max solution though - simply because it's easier to read when you come back to the code later.
-1: this is not micro-optimisation; this is choosing an appropriate algorithm. Your algorithm is O(n) when there is a simple O(1) choice.
This is what happens when "premature optimization is the root of all evil" becomes an inviolable religious tenet for the inept instead of a half-serious remark on some occasional pattern of behaviour.