ChatGPT解决这个技术问题 Extra ChatGPT

Fast ceiling of an integer division in C / C++

Given integer values x and y, C and C++ both return as the quotient q = x/y the floor of the floating point equivalent. I'm interested in a method of returning the ceiling instead. For example, ceil(10/5)=2 and ceil(11/5)=3.

The obvious approach involves something like:

q = x / y;
if (q * y < x) ++q;

This requires an extra comparison and multiplication; and other methods I've seen (used in fact) involve casting as a float or double. Is there a more direct method that avoids the additional multiplication (or a second division) and branch, and that also avoids casting as a floating point number?

the divide instruction often returns both quotient and remainder at the same time so there's no need to multiply, just q = x/y + (x % y != 0); is enough
@LưuVĩnhPhúc Seriously you need to add that as the answer. I just used that for my answer during a codility test. It worked like a charm though I am not certain how the mod part of the answer works but it did the job.
@AndreasGrapentin the answer below by Miguel Figueiredo was submitted nearly a year before Lưu Vĩnh Phúc left the comment above. While I understand how appealing and elegant Miguel's solution is, I'm not inclined to change the accepted answer at this late date. Both approaches remain sound. If you feel strongly enough about it, I suggest you show your support by up-voting Miguel's answer below.
Strange, I have not seen any sane measurement or analysis of the proposed solutions. You talk about speed on near-the-bone, but there is no discussion of architectures, pipelines, branching instructions and clock cycles.

K
Kamil

For positive numbers

unsigned int x, y, q;

To round up ...

q = (x + y - 1) / y;

or (avoiding overflow in x+y)

q = 1 + ((x - 1) / y); // if x != 0

@bitc: For negative numbers, I believe C99 specifies round-to-zero, so x/y is the ceiling of the division. C90 didn't specify how to round, and I don't think the current C++ standard does either.
Note: This might overflow. q = ((long long)x + y - 1) / y will not. My code is slower though, so if you know that your numbers will not overflow, you should use Sparky's version.
The second one has a problem where x is 0. ceil(0/y) = 0 but it returns 1.
@OmryYadan would x == 0 ? 0 : 1 + ((x - 1) / y) resolve this safely and efficiently?
M
Miguel Figueiredo

For positive numbers:

    q = x/y + (x % y != 0);

most common architecture's divide instruction also includes remainder in its result so this really needs only one division and would be very fast
T
Tatsuyuki Ishi

Sparky's answer is one standard way to solve this problem, but as I also wrote in my comment, you run the risk of overflows. This can be solved by using a wider type, but what if you want to divide long longs?

Nathan Ernst's answer provides one solution, but it involves a function call, a variable declaration and a conditional, which makes it no shorter than the OPs code and probably even slower, because it is harder to optimize.

My solution is this:

q = (x % y) ? x / y + 1 : x / y;

It will be slightly faster than the OPs code, because the modulo and the division is performed using the same instruction on the processor, because the compiler can see that they are equivalent. At least gcc 4.4.1 performs this optimization with -O2 flag on x86.

In theory the compiler might inline the function call in Nathan Ernst's code and emit the same thing, but gcc didn't do that when I tested it. This might be because it would tie the compiled code to a single version of the standard library.

As a final note, none of this matters on a modern machine, except if you are in an extremely tight loop and all your data is in registers or the L1-cache. Otherwise all of these solutions will be equally fast, except for possibly Nathan Ernst's, which might be significantly slower if the function has to be fetched from main memory.


There was an easier way to fix overflow, simply reduce y/y: q = (x > 0)? 1 + (x - 1)/y: (x / y);
-1: this is an inefficient way, as it trades a cheap * for a costly %; worse than the OP approach.
No, it does not. As I explained in the answer, the % operator is free when you already perform the division.
Then q = x / y + (x % y > 0); is easier than ? : expression?
It depends on what you mean by "easier." It may or may not be faster, depending on how the compiler translates it. My guess would be slower but I would have to measure it to be sure.
N
Nathan Ernst

You could use the div function in cstdlib to get the quotient & remainder in a single call and then handle the ceiling separately, like in the below

#include <cstdlib>
#include <iostream>

int div_ceil(int numerator, int denominator)
{
        std::div_t res = std::div(numerator, denominator);
        return res.rem ? (res.quot + 1) : res.quot;
}

int main(int, const char**)
{
        std::cout << "10 / 5 = " << div_ceil(10, 5) << std::endl;
        std::cout << "11 / 5 = " << div_ceil(11, 5) << std::endl;

        return 0;
}

As an interesting case of the double bang, you could also return res.quot + !!res.rem; :)
Doesn't ldiv always promote the arguments into long long's? And doesn't that cost anything, up-casting or down-casting?
@einpoklum: std::div is overloaded for int, long, long long and intmax_t (the latter two since C++11); whether it internally promotes would be an implementation detail (and I can't see a strong reason for why they wouldn't implement it independently for each). ldiv promotes, but std::div shouldn't need to.
c
cubuspl42

There's a solution for both positive and negative x but only for positive y with just 1 division and without branches:

int div_ceil(int x, int y) {
    return x / y + (x % y > 0);
}

Note, if x is positive then division is towards zero, and we should add 1 if reminder is not zero.

If x is negative then division is towards zero, that's what we need, and we will not add anything because x % y is not positive


interesting, because there are common cases with y being constant
mod requires division so its not just 1 division here, but maybe complier can optimize two similar divisions into one.
This comment implies that modern architectures can divide and calculate module with one instruction. That still requires a smart compiler, of course.
B
Ben Voigt

How about this? (requires y non-negative, so don't use this in the rare case where y is a variable with no non-negativity guarantee)

q = (x > 0)? 1 + (x - 1)/y: (x / y);

I reduced y/y to one, eliminating the term x + y - 1 and with it any chance of overflow.

I avoid x - 1 wrapping around when x is an unsigned type and contains zero.

For signed x, negative and zero still combine into a single case.

Probably not a huge benefit on a modern general-purpose CPU, but this would be far faster in an embedded system than any of the other correct answers.


Your else will always return 0, no need to calculate anything.
@Ruud: not true. Consider x=-45 and y=4
G
Greg Kramida

I would have rather commented but I don't have a high enough rep.

As far as I am aware, for positive arguments and a divisor which is a power of 2, this is the fastest way (tested in CUDA):

//example y=8
q = (x >> 3) + !!(x & 7);

For generic positive arguments only, I tend to do it like so:

q = x/y + !!(x % y);

It would be interesting to see how q = x/y + !!(x % y); stacks up against q = x/y + (x % y == 0); and the q = (x + y - 1) / y; solutions performance-wise in contemporary CUDA.
seems like q = x/y + (x % y == 0); should be q = x/y + (x % y != 0); instead
E
Eliahu Aaron

This works for positive or negative numbers:

q = x / y + ((x % y != 0) ? !((x > 0) ^ (y > 0)) : 0);

If there is a remainder, checks to see if x and y are of the same sign and adds 1 accordingly.


Doesn't work with a negative x and a positive y.
C
Community

simplified generic form,

int div_up(int n, int d) {
    return n / d + (((n < 0) ^ (d > 0)) && (n % d));
} //i.e. +1 iff (not exact int && positive result)

For a more generic answer, C++ functions for integer division with well defined rounding strategy


e
evoskuil

For signed or unsigned integers.

q = x / y + !(((x < 0) != (y < 0)) || !(x % y));

For signed dividends and unsigned divisors.

q = x / y + !((x < 0) || !(x % y));

For unsigned dividends and signed divisors.

q = x / y + !((y < 0) || !(x % y));

For unsigned integers.

q = x / y + !!(x % y);

Zero divisor fails (as with a native operation). Cannot cause overflow.

Corresponding floored and modulo constexpr implementations here, along with templates to select the necessary overloads (as full optimization and to prevent mismatched sign comparison warnings):

https://github.com/libbitcoin/libbitcoin-system/wiki/Integer-Division-Unraveled


c
chen

Compile with O3, The compiler performs optimization well.

q = x / y;
if (x % y)  ++q;